Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion: add a gate for new system privileges #98419

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 10, 2023

A 22.2/23.1 mixed version cluster cannot handle new system privileges well. This commit gates their usage and adds a test.

Without this gate, the included test would fail and users would not be able to log in to nodes running on the old binary.

Epic: None
Release note: None

@rafiss rafiss requested review from Santamaura, jayshrivastava and a team March 10, 2023 22:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss force-pushed the gate-modifysqlclustersetting branch from 3d26152 to 0428566 Compare March 10, 2023 22:53
Copy link
Contributor

@jayshrivastava jayshrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this.

@rafiss rafiss force-pushed the gate-modifysqlclustersetting branch from 0428566 to 96a8e23 Compare March 13, 2023 14:28
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 13, 2023

tftr!

bors r=jayshrivastava

@craig
Copy link
Contributor

craig bot commented Mar 13, 2023

Build failed:

A 22.2/23.1 mixed version cluster cannot handle new system privileges
well. This commit gates their usage and adds a test.

Without this gate, the included test would fail and users would not be
able to log in to nodes running on the old binary.

Release note: None
@rafiss rafiss force-pushed the gate-modifysqlclustersetting branch from 96a8e23 to fc50c99 Compare March 13, 2023 20:02
@rafiss rafiss requested a review from a team as a code owner March 13, 2023 20:02
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 13, 2023

bors r=jayshrivastava

@craig
Copy link
Contributor

craig bot commented Mar 13, 2023

Build succeeded:

@craig craig bot merged commit 2d63378 into cockroachdb:master Mar 13, 2023
@rafiss rafiss deleted the gate-modifysqlclustersetting branch March 14, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants