Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: skip TestLowercaseFunctionNames under --short #98417

Conversation

irfansharif
Copy link
Contributor

It takes ~350s on my M1, and is the lone straggler.

$ dev lint --short
...
    --- PASS: TestLint/TestEnvutil (1.51s)
    --- PASS: TestLint/TestCopyrightHeaders (0.62s)
    --- PASS: TestLint/TestCrlfmt (8.05s)
    --- PASS: TestLint/TestGofmtSimplify (9.66s)
    --- PASS: TestLint/TestMissingLeakTest (5.48s)
    --- PASS: TestLint/TestLowercaseFunctionNames (357.81s)
PASS

Release note: None

It takes ~350s on my M1, and is the lone straggler.

    $ dev lint --short
    ...
        --- PASS: TestLint/TestEnvutil (1.51s)
        --- PASS: TestLint/TestCopyrightHeaders (0.62s)
        --- PASS: TestLint/TestCrlfmt (8.05s)
        --- PASS: TestLint/TestGofmtSimplify (9.66s)
        --- PASS: TestLint/TestMissingLeakTest (5.48s)
        --- PASS: TestLint/TestLowercaseFunctionNames (357.81s)
    PASS

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@irfansharif
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 11, 2023

Build succeeded:

@craig craig bot merged commit 5b2a567 into cockroachdb:master Mar 11, 2023
@irfansharif irfansharif deleted the 230310.skip-TestLowercaseFunctionNames-short branch March 11, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants