Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenantcapabilitiesauthorizer: vmodule capability not found log #98413

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

adityamaru
Copy link
Contributor

This logline shows up a lot in unit tests that run inside a tenant. This change puts it behind vmodule=2.

Release note: None
Epic: none

This logline shows up a lot in unit tests that run inside a tenant.
This change puts it behind vmodule=2.

Release note: None
Epic: none
@adityamaru adityamaru requested review from arulajmani and ecwall March 10, 2023 21:42
@adityamaru adityamaru requested a review from a team as a code owner March 10, 2023 21:42
@blathers-crl
Copy link

blathers-crl bot commented Mar 10, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

Let me know if this is not a change we want or if we should put it behind a lower/higher vmodule

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. Thanks for the patch!

@adityamaru
Copy link
Contributor Author

TFTR!

bors r=arulajmani

@craig
Copy link
Contributor

craig bot commented Mar 11, 2023

Build succeeded:

@craig craig bot merged commit 884ff98 into cockroachdb:master Mar 11, 2023
@adityamaru adityamaru deleted the loud-log branch March 11, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants