roachtest: Added a declarative schema changer job compatibility tests

[Xiang-Gu]

We added a roachtest to test declarative schema change job compatibility, both
forward and backward, in a mixed version state (V22_2/V23_1).

Fixes: #89345
Epic: None
Release Note: None

[cockroach-teamcity]

This change is 

[fqazi]

This gives good coverage of at least basic sanity between the two releases.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @srosenberg, and @Xiang-Gu)

---

-- commits line 4 at r1:
spelling: revived

typo: ensured => ensures

Code quote:

revivied

---

pkg/cmd/roachtest/tests/mixed_version_job_compatibility_in_declarative_schema_changer.go line 89 at r1 (raw file):

) versionStep {
	return func(ctx context.Context, t test.Test, u *versionUpgradeTest) {
		planAndRunSchemaChange(ctx, t, c, nodeIDs.RandNode(), `DROP SEQUENCE testdb.testsc.s`)

There is overlap here, we can probably have functions that call each other. Also, I'm wondering if master should only test against the previous release, and we backport the roachtest to 22.2

[chengxiong-ruan]

Could you also update the PR description. I was looking for another test for V22_1/V22_2 heh (the commit message is correct :)). Thanks.

[Xiang-Gu]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @fqazi, @herkolategan, and @srosenberg)

---

-- commits line 4 at r1:

Previously, fqazi (Faizan Qazi) wrote…

spelling: revived

typo: ensured => ensures

Done.

---

pkg/cmd/roachtest/tests/mixed_version_job_compatibility_in_declarative_schema_changer.go line 89 at r1 (raw file):

Previously, fqazi (Faizan Qazi) wrote…

There is overlap here, we can probably have functions that call each other. Also, I'm wondering if master should only test against the previous release, and we backport the roachtest to 22.2

I don't want to separate the overlap here because those stmts have "dependency" (e.g. we should alter a table before dropping it). However, I do like your idea of having only one roachtest on master and backporting the other one to 22.2 (#98541).

[Xiang-Gu]

@chengxiong-ruan Sorry, I separate that roachtest into a backport PR to 22.2.

[Xiang-Gu]

TFTR!

bors r+

[craig]

👎 Rejected by code reviews

[ajwerner]

LGTM

[ajwerner]

bors r+

[craig]

👎 Rejected by code reviews

There were only nits

[ajwerner]

bors r+

[craig]

This PR was included in a batch that was canceled, it will be automatically retried

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)