Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statusccl: stop serving /_status/nodes to tenants #98398

Merged
merged 1 commit into from
Mar 14, 2023
Merged

statusccl: stop serving /_status/nodes to tenants #98398

merged 1 commit into from
Mar 14, 2023

Conversation

matthewtodd
Copy link
Contributor

Fixes #98057.

This reverts the work of #93268, which is no longer necessary now that we are eagerly capturing region information at execution time in #95449.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Fixes #98057.

This reverts the work of #93268, which is no longer necessary now that
we are eagerly capturing region information at execution time in #95449.

Release note: None
@matthewtodd matthewtodd requested a review from a team March 14, 2023 14:45
@matthewtodd matthewtodd marked this pull request as ready for review March 14, 2023 14:45
@matthewtodd matthewtodd requested a review from a team March 14, 2023 14:45
@matthewtodd matthewtodd requested review from a team as code owners March 14, 2023 14:45
@matthewtodd matthewtodd requested a review from a team March 14, 2023 14:45
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd)

@matthewtodd
Copy link
Contributor Author

Test failure is #98213, re-running.

@dhartunian
Copy link
Collaborator

@matthewtodd I've got a PR in flight that should resolve the flake: #47121

@matthewtodd
Copy link
Contributor Author

Waiting on #98410 before landing this.

@matthewtodd
Copy link
Contributor Author

bors r+

1 similar comment
@matthewtodd
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 14, 2023

Build succeeded:

@craig craig bot merged commit 7f2afbc into cockroachdb:master Mar 14, 2023
@matthewtodd matthewtodd deleted the remove-tenant-nodes branch March 14, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

statusccl: stop serving /_status/nodes to tenants
4 participants