Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitenant: add AdminScatterRequest capability #98395

Merged
merged 4 commits into from
Mar 11, 2023
Merged

multitenant: add AdminScatterRequest capability #98395

merged 4 commits into from
Mar 11, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Mar 10, 2023

Fixes #98394

  1. Add a new tenantcapabilities.CanAdminScatter capability.
  2. Check capability in Authorizer.HasCapabilityForBatch.

Release note: None

@ecwall ecwall requested a review from a team as a code owner March 10, 2023 19:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ecwall ecwall requested review from rafiss and arulajmani March 10, 2023 19:18
ecwall added 4 commits March 10, 2023 16:09
Get cluster settings and capabilities directly from testCase instead of
passing through testClusterCfg.

Release note: None
Exclude capabilities from `tenant` logic test, `restore-tenants` data driven
test. These tests do not set or depend on capabilities and they are tested
elsewhere.

Release note: None
Filter out static capabilities in `subtest node_tenant_capabilities_cache`.

Release note: None
Fixes #98394

1) Add a new `tenantcapabilities.CanAdminScatter` capability.
2) Check capability in `Authorizer.HasCapabilityForBatch`.

Release note: None
@ecwall ecwall requested a review from a team as a code owner March 10, 2023 22:15
@ecwall ecwall requested review from msbutler and removed request for a team March 10, 2023 22:15
@craig
Copy link
Contributor

craig bot commented Mar 11, 2023

Build failed:

@ecwall
Copy link
Contributor Author

ecwall commented Mar 11, 2023

bors r=knz

@craig
Copy link
Contributor

craig bot commented Mar 11, 2023

Build succeeded:

@craig craig bot merged commit e417cdd into cockroachdb:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multitenant: add AdminScatterRequest capability
3 participants