roachtest: fix clusterImpl.IsLocal() #98371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
requested review from
srosenberg and
smg260
and removed request for
a team
|
This change is |
renatolabs
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Thank you for fixing! LGTM once we reuse the existing function in the config package.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @msbutler, @smg260, and @srosenberg)
pkg/cmd/roachtest/cluster.go line 2385 at r1 (raw file):
func (c *clusterImpl) IsLocal() bool { return strings.HasPrefix(c.name, "local")
We should use config.IsLocalClusterName.
msbutler
force-pushed
the
butler-roachtest-islocal
branch
from
9ea2707 to
0a4da2f
Compare
|
Done! |
msbutler
force-pushed
the
butler-roachtest-islocal
branch
from
0a4da2f to
9b13055
Compare
Previously, c.IsLocal() would always return false because local clusters have a time based suffix. This patch changes c.IsLocal() to return true if the cluster name is prefixed with "local". Epic: none Release note: none
msbutler
force-pushed
the
butler-roachtest-islocal
branch
from
9b13055 to
8cb2803
Compare
|
bors r=renatolabs |
|
Build failed: |
|
bors r=retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, c.IsLocal() would always return false because local clusters have a time based suffix. This patch changes c.IsLocal() to return true if the cluster name is prefixed with "local".
Epic: none
Release note: none