Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: backupccl: fix off by one index in fileSSTSink file extension #98344

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Mar 9, 2023

Backport 1/1 commits from #98041.

/cc @cockroachdb/release


Currently, the logic that extends the last flushed file fileSSTSink does not trigger if there is only one flushed file. This failure to extend the first flushed file can result in file entries in the backup manifest with duplicate start keys. For example, if the first export response written to the sink contains partial entries of a single key a, then the span of the first file will be a-a, and the span of the subsequent file will always be a-<end_key>. The presence of these duplicate start keys breaks the encoding of the external manifest files list SST as the file path + start key combination in the manifest are assumed to be unique.

Fixes #97953

Release note: None

Release justification: bug fix that may prevent writing of backup manifest files SST

Currently, the logic that extends the last flushed file fileSSTSink does not
trigger if there is only one flushed file. This failure to extend the first
flushed file can result in file entries in the backup manifest with duplicate
start keys. For example, if the first export response written to the sink
contains partial entries of a single key `a`, then the span of the first file
will be `a-a`, and the span of the subsequent file will always be
`a-<end_key>`. The presence of these duplicate start keys breaks the encoding
of the external manifest files list SST as the file path + start key
combination in the manifest are assumed to be unique.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Mar 9, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713 rhu713 marked this pull request as ready for review March 14, 2023 15:11
@rhu713 rhu713 requested a review from a team as a code owner March 14, 2023 15:11
@rhu713 rhu713 requested review from msbutler and removed request for a team March 14, 2023 15:11
@rhu713 rhu713 merged commit 5eac5d7 into cockroachdb:release-22.1 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants