Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: enable TestSQLStatsDataDriven #98337

Merged
merged 1 commit into from
Mar 15, 2023
Merged

sql: enable TestSQLStatsDataDriven #98337

merged 1 commit into from
Mar 15, 2023

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Mar 9, 2023

Adding retry logic to the execute command, and
enabling the test. All previous builds with failures
are no longer available. No failures on testing
locally with stress.

Epic: none
Closes: #89861

Release note: none

@j82w j82w requested a review from a team March 9, 2023 20:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @j82w)

@j82w
Copy link
Contributor Author

j82w commented Mar 10, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 10, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 10, 2023

Build failed:

Adding retry logic to the execute command, and
enabling the test. All previous builds with failures
are no longer available. No failures on testing
locally with stress.

Epic: none
Closes: #89861

Release note: none
@j82w
Copy link
Contributor Author

j82w commented Mar 14, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 14, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 14, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 14, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 15, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 15, 2023

Build succeeded:

@craig craig bot merged commit 9b43dc5 into cockroachdb:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestSQLStatsDataDriven is flaky
3 participants