Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboards: add replica cpu to repl dashboard #98270

Merged
merged 3 commits into from
Mar 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
// licenses/APL.txt.

import React from "react";
import _ from "lodash";

import { LineGraph } from "src/views/cluster/components/linegraph";
import { Axis, Metric } from "src/views/shared/components/metricQuery";
Expand Down Expand Up @@ -58,7 +57,7 @@ export default function (props: GraphDashboardProps) {
tooltip={`The number of replicas on each node.`}
>
<Axis label="replicas">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.replicas"
Expand All @@ -75,7 +74,7 @@ export default function (props: GraphDashboardProps) {
receives and coordinates all read and write requests for its range.`}
>
<Axis label="leaseholders">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.replicas.leaseholders"
Expand All @@ -87,11 +86,13 @@ export default function (props: GraphDashboardProps) {
</LineGraph>,

<LineGraph
title="Average Queries per Node"
tooltip={`Exponentially weighted moving average of the number of KV batch requests processed by leaseholder replicas on each node per second. Tracks roughly the last 30 minutes of requests. Used for load-based rebalancing decisions.`}
title="Average Replica Queries per Node"
tooltip={`Moving average of the number of KV batch requests processed by
leaseholder replicas on each node per second. Tracks roughly the last
30 minutes of requests. Used for load-based rebalancing decisions.`}
>
<Axis label="queries">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.rebalancing.queriespersecond"
Expand All @@ -102,12 +103,30 @@ export default function (props: GraphDashboardProps) {
</Axis>
</LineGraph>,

<LineGraph
title="Average Replica CPU per Node"
tooltip={`Moving average of all replica CPU usage on each node per second.
Tracks roughly the last 30 minutes of usage. Used for load-based
rebalancing decisions.`}
>
<Axis units={AxisUnits.Duration} label="CPU time">
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.rebalancing.cpunanospersecond"
title={nodeDisplayName(nodeDisplayNameByID, nid)}
sources={storeIDsForNode(storeIDsByNodeID, nid)}
/>
))}
</Axis>
</LineGraph>,

<LineGraph
title="Logical Bytes per Node"
tooltip={<LogicalBytesGraphTooltip />}
>
<Axis units={AxisUnits.Bytes} label="logical store size">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.totalbytes"
Expand Down Expand Up @@ -181,7 +200,7 @@ export default function (props: GraphDashboardProps) {

<LineGraph title="Snapshot Data Received" sources={storeSources}>
<Axis label="bytes" units={AxisUnits.Bytes}>
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<>
<Metric
key={nid}
Expand All @@ -207,7 +226,7 @@ export default function (props: GraphDashboardProps) {
tooltip={ReceiverSnapshotsQueuedTooltip}
>
<Axis label="snapshots" units={AxisUnits.Count}>
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.range.snapshots.recv-queue"
Expand All @@ -223,7 +242,7 @@ export default function (props: GraphDashboardProps) {
tooltip={CircuitBreakerTrippedReplicasTooltip}
>
<Axis label="replicas">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.kv.replica_circuit_breaker.num_tripped_replicas"
Expand All @@ -240,7 +259,7 @@ export default function (props: GraphDashboardProps) {
tooltip={CircuitBreakerTrippedEventsTooltip}
>
<Axis label="events">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.kv.replica_circuit_breaker.num_tripped_events"
Expand All @@ -257,7 +276,7 @@ export default function (props: GraphDashboardProps) {
tooltip={PausedFollowersTooltip}
>
<Axis label="replicas">
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.admission.raft.paused_replicas"
Expand Down Expand Up @@ -341,7 +360,7 @@ export default function (props: GraphDashboardProps) {
</LineGraph>,
<LineGraph title="Decommissioning Errors" sources={storeSources}>
<Axis label="replicas" units={AxisUnits.Count}>
{_.map(nodeIDs, nid => (
{nodeIDs.map(nid => (
<Metric
key={nid}
name="cr.store.queue.replicate.replacedecommissioningreplica.error"
Expand Down