release: split release process #98240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rail
added
C-enhancement
|
This change is |
rail
force-pushed
the
split-release-3
branch
2 times, most recently
from
aefe603 to
f9e6b3d
Compare
|
I think this is ready to go! I tested it and so far it works as expected. |
rail
force-pushed
the
split-release-3
branch
2 times, most recently
from
c029def to
66d441f
Compare
jlinder
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Suggested file name for the copied version of this file:
sign_macos_staged_release.sh
There was a problem hiding this comment.
Suggested file name:
publish-staged-cockroach-release.sh
Previously, the release publishing step contained building, signing and other operations that can happen in advance. This PR splits the release process into 2 steps: build/sign and publishing. Artifacts generated during the build stage are published to a "staged" bucket and copied to the final bucket during the publishing phase. * Extracted docker verification into a function. * The version is read from a file now. * Use `gsutil` in MacOS signing in order to download from private repos. * Removed `PRE_RELEASE` variable set from TeamCity in favour of "guessing" it from the version. * Simplified dry-run logic to define version/build names, because the version is defined in the source code now. * The publishing phase updates docker image packages. Epic: RE-307 Fixes: RE-211 Release note: None
|
bors r=jlinder |
|
Build succeeded: |
|
blathers backport release-23.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the release publishing step contained building, signing and other operations that can happen in advance.
This PR splits the release process into 2 steps: build/sign and publishing. Artifacts generated during the build stage are published to a "staged" bucket and copied to the final bucket during the publishing phase.
gsutilin MacOS signing in order to download from private repos.PRE_RELEASEvariable set from TeamCity in favour of "guessing" it from the version.Epic: RE-307
Fixes: RE-211
Release note: None