cdc: show all changefeed jobs in SHOW CHANGEFEED JOBS
#98175
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
There doesn't seem to be a reason for why we limit it to 12h. There is a mention of it in the original PR #64956 (review). Perhaps this limit was added due to instability in the jobs system / virtual tables. There's no discussion on Slack which I could find either. |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball)
|
The virtual index causes a lot of tests to fail in many different ways, including but not limited to mixed version tests. I'm going to hold off on merging for now. |
jayshrivastava
force-pushed
the
show-changefeed-jobs
branch
from
91cf297 to
b35f896
Compare
jayshrivastava
force-pushed
the
show-changefeed-jobs
branch
2 times, most recently
from
67a69a3 to
5065385
Compare
Release note (general change): Previously, the output of `SHOW CHANGEFEED JOBS` was limited to show unfinished jobs and finished jobs from the last 14 days. This change makes the command show all changefeed jobs, regardless of if they finished and when they finished. Note that jobs still obey the cluster setting `jobs.retention_time`. Completed jobs older than that time are deleted. Fixes: cockroachdb#97883 Epic: None
This change adds a virtual index on the `job_type` column of `crdb_internal.jobs`. This change should make queries on that table which filter on job type (such as `SHOW CHANGEFEED JOBS`) more efficient. Release note: None
jayshrivastava
force-pushed
the
show-changefeed-jobs
branch
from
5065385 to
85d878c
Compare
|
bors r=HonoreDB |
|
Build succeeded: |
cdc: show all changefeed jobs in SHOW CHANGEFEED JOBS
Release note (general change): Previously, the output of
SHOW CHANGEFEED JOBSwas limited to show unfinished jobs and finished jobs from the last 14 days. This change makes the command show all changefeed jobs, regardless of if they finished and when they finished. Note that jobs still obey the cluster settingjobs.retention_time. Completed jobs older than that time are deleted.Fixes: #97883
jobs: add virtual index for job_type in crdb_internal.jobs
This change adds a virtual index on the
job_typecolumnof
crdb_internal.jobs. This change should make querieson that table which filter on job type (such as
SHOW CHANGEFEED JOBS) more efficient.Release note: None
Epic: None