sqlproxyccl: change denylist into an access control list #98153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pjtatlow
changed the title
pjtatlow
changed the title
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
2 times, most recently
from
205ecd1 to
c78fd0c
Compare
pjtatlow
changed the title
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
from
c78fd0c to
865224d
Compare
jeffswenson
reviewed
Mar 8, 2023
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
3 times, most recently
from
72a1fb5 to
202bb09
Compare
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
from
202bb09 to
b73d22c
Compare
Part of: https://cockroachlabs.atlassian.net/browse/CC-8136 Release note: None
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
3 times, most recently
from
2b23fa3 to
ad0a74f
Compare
jeffswenson
reviewed
Mar 16, 2023
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
from
ad0a74f to
4862c96
Compare
To support an IP Allowlist in the sqlproxy, this change extends the denylist code to make the Watcher support multiple AccessControllers. Each AccessController is consulted before allowing a connection through, and rechecked on any changes to the underlying files. The sqlproxy will also fail to start if it begins with an invalid allow or deny list, but if invalid files are written later then it increments a new error metric so we can be alerted and take action to fix it. Part of: https://cockroachlabs.atlassian.net/browse/CC-8136 Release note: None
pjtatlow
force-pushed
the
sqlproxy-access-control-list
branch
from
4862c96 to
a20ff9b
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support an IP Allowlist in the sqlproxy, this change extends
the denylist code to make the Watcher support multiple AccessControllers.
Each AccessController is consulted before allowing a connection through,
and rechecked on any changes to the underlying files.
Part of: CC-8136