pkg/jobs: remove un-needed check for job_type column existence
#98083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
2 times, most recently
from
86aee3a to
1a43ef9
Compare
healthy-pod
changed the title
job_type column existence
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
from
1a43ef9 to
f0f6aae
Compare
adityamaru
approved these changes
Mar 17, 2023
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
from
f0f6aae to
0f14617
Compare
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
from
0f14617 to
2644d14
Compare
healthy-pod
requested review from
rhu713
and removed request for
ajwerner and
a team
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
from
2644d14 to
04446d0
Compare
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
from
04446d0 to
f802ac4
Compare
This code change makes the job creation code depend solely on the version gate to check if `V23_1AddTypeColumnToJobsTable` migration ran. `TestTelemetry/schema` was rewritten. Release note: None Epic: CRDB-21741
healthy-pod
force-pushed
the
mixed-version-bootstrap
branch
from
f802ac4 to
ac602b3
Compare
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change makes the job creation code depend solely
on the version gate to check if
V23_1AddTypeColumnToJobsTablemigration ran.
TestTelemetry/schemawas rewritten.Release note: None
Epic: CRDB-21741