spanconfig: deflake spanconfigreconcilerccl/TestDataDriven #98082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#98038. This test set up two protection records over two schema objects at two timestamps ts=3 and ts=4. /Table/10{6-7} protection_policies=[{ts: 3} {ts: 4}] /Table/10{7-8} protection_policies=[{ts: 3} {ts: 4}] When it later released those protection records: release record-id=3 release record-id=4 ---- It asserted that the span config mutations showed that we did infact get rid of the protected state: mutations ---- delete /Table/10{6-7} upsert /Table/10{6-7} range default delete /Table/10{7-8} upsert /Table/10{7-8} range default But since release of these protections was non-atomic, in cockroachdb#98038 we observed the following transition instead. delete /Table/10{6-7} upsert /Table/10{6-7} protection_policies=[{ts: 4}] delete /Table/10{7-8} upsert /Table/10{7-8} protection_policies=[{ts: 4}] delete /Table/10{6-7} upsert /Table/10{6-7} range default delete /Table/10{7-8} upsert /Table/10{7-8} range default That is, we first got rid of the record with ts=3 and only then got rid of ts=4. We just rewrite the test to assert on the final state of the records that show no remaining protections, instead of trying to add synchronization for mutations. Release note: None
|
This change is |
arulajmani
approved these changes
Mar 6, 2023
|
bors r+ |
|
Build succeeded: |
|
blathers backport 22.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98038. This test set up two protection records over two schema objects at two timestamps ts=3 and ts=4.
When it later released those protection records:
It asserted that the span config mutations showed that we did infact get rid of the protected state:
But since release of these protections was non-atomic, in #98038 we observed the following transition instead.
That is, we first got rid of the record with ts=3 and only then got rid of ts=4. We just rewrite the test to assert on the final state of the records that show no remaining protections, instead of trying to add synchronization for mutations.
Release note: None