go.mod: bump Pebble to e9a8c4ad65c5 #98078
Conversation
|
This change is |
There was a problem hiding this comment.
Looks like there are some interface changes that we need to account for.
Reviewable status:
complete! 0 of 0 LGTMs obtained
RaduBerinde
force-pushed
the
radu/pebble-master-e9a8c4ad65c5
branch
from
10a476f to
0126cad
Compare
There was a problem hiding this comment.
Yeah, I forgot about the writable API change. The changes were more extensive than I expected. PTAL
Reviewable status:
RaduBerinde
force-pushed
the
radu/pebble-master-e9a8c4ad65c5
branch
from
0126cad to
7186fa6
Compare
There was a problem hiding this comment.
I took a fairly mechanical pass through the changes.
Reviewed 4 of 4 files at r1, 32 of 32 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
pkg/storage/sst_writer.go line 461 at r2 (raw file):
} //// Flush implements the same interface as the standard library's *bufio.Writer's
nit: dead code?
e9a8c4ad sstable: fix error path in writer.Close fdf055dd db: improve documentation of tableNewIters 717cbce0 db: add Options.LoggerAndTracer for tracing 7751e381 objstorage: better Writable API 78c8001e db: add missing error check in TestIngestLoad 1334233b metamorphic: add unit test for Options propagation ed824c76 objstorage: rename ReadaheadHandle to ReadHandle The "better Writable API" changed the interface to write to SST files. This commit contains the required changes in Cockroach: MemFile is now MemObject and implements objstorage.Writable. There were many test places that were using MemFile as just an io.Writer; these are updated to just use bytes.Buffer. Informs cockroachdb#97350. Release note: none Epic: none
RaduBerinde
force-pushed
the
radu/pebble-master-e9a8c4ad65c5
branch
from
7186fa6 to
90ba5a1
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/storage/sst_writer.go line 461 at r2 (raw file):
Previously, nicktrav (Nick Travers) wrote…
nit: dead code?
Fixed.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
e9a8c4ad sstable: fix error path in writer.Close
fdf055dd db: improve documentation of tableNewIters
717cbce0 db: add Options.LoggerAndTracer for tracing
7751e381 objstorage: better Writable API
78c8001e db: add missing error check in TestIngestLoad
1334233b metamorphic: add unit test for Options propagation
ed824c76 objstorage: rename ReadaheadHandle to ReadHandle
Informs #97350.
Release note: none
Epic: none