Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: add gcassert job in TC #98011

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Mar 3, 2023

This simple job generates code then runs gcassert as a standalone
binary.

Closes #65485.

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This simple job generates code then runs `gcassert` as a standalone
binary.

Closes cockroachdb#65485.

Epic: none
Release note: None
@rickystewart
Copy link
Collaborator Author

rickystewart commented Mar 4, 2023

Successful run. I will do a couple more runs to validate. Before merging I will put this in the Bazel CI hierarchy.

@rickystewart rickystewart requested a review from healthy-pod March 4, 2023 01:45
@rickystewart rickystewart marked this pull request as ready for review March 4, 2023 01:45
@rickystewart rickystewart requested a review from a team as a code owner March 4, 2023 01:45
Copy link
Contributor

@healthy-pod healthy-pod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 5 minutes, nice 😎

@rickystewart
Copy link
Collaborator Author

bors r=healthy-pod

@craig
Copy link
Contributor

craig bot commented Mar 6, 2023

Build succeeded:

@craig craig bot merged commit 856658b into cockroachdb:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: TestLint/TestGCAssert fails when run under Bazel
3 participants