release: update-versions bug fixes
#98010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two issues found in the `update-versions` automation found while attempting to run it in the process of releasing 22.2.6. * the `isLatestStableBranch` function would only consider the current released version to be the latest if it is greater than the last known release. However, this automation is run after the release is published and the corresponding tag created, so the comparison should actually be that the released version be greater than or equal to the latest release. * the `set-cockroach-version` part of the update should only run if we are releasing something v23 or newer. This updates the logic to ignore `version.txt` related updates otherwise. Epic: none Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Output is not what I expected it to be on 22.2.6: https://teamcity.cockroachdb.com/buildConfiguration/Internal_Cockroach_Release_Process_CreateVersionUpdatePRs/8918691?buildTab=log&focusLine=3&linesState=282.286 |
|
@rail friendly ping. Could you take a look when you get the chance, please? |
|
Sure! |
rail
approved these changes
Mar 10, 2023
|
bors r=rail TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues found in the
update-versionsautomation found while attempting to run it in the process of releasing 22.2.6.the
isLatestStableBranchfunction would only consider the current released version to be the latest if it is greater than the last known release. However, this automation is run after the release is published and the corresponding tag created, so the comparison should actually be that the released version be greater than or equal to the latest release.the
set-cockroach-versionpart of the update should only run if we are releasing something v23 or newer. This updates the logic to ignoreversion.txtrelated updates otherwise.Epic: none
Release note: None