Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy: fix data race in test #98006

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 3, 2023

The test code had two goroutines that were both trying to assign to the same err variable.

fixes #97838

Release note: None

The test code had two goroutines that were both trying to assign to the
same `err` variable.

Release note: None
@rafiss rafiss requested review from otan and cucaroach March 3, 2023 22:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Mar 6, 2023

tftr!

bors r=otan

@craig
Copy link
Contributor

craig bot commented Mar 6, 2023

Build succeeded:

@craig craig bot merged commit 1d4feea into cockroachdb:master Mar 6, 2023
@rafiss rafiss deleted the fix-copy-test-data-race branch March 6, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/sql/copy/copy_test: TestShowQueriesIncludesCopy failed
3 participants