Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fixes for console errors #98004

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Mar 3, 2023

Fixes for problems causing warnings on console.
Those didn't cause any actual error, just warnings (but sending out as error on datadog):

  • Change <p> to <span fixes Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

  • Change renderSuffix to suffix fixes React does not recognize the renderSuffix prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase rendersuffix instead.

  • Add key attribute to list fixes Warning: Each child in a list should have a unique "key" prop.

  • Adding checks that were causing some crashed the first time a page was open with no cache.
    Fixes error on reading transactionInsights #97902

Release note: None

Fixes for problems causing warnings on console.
Those didn't cause any actual error, just warnings:

- Change `<p>` to `<span` fixes
`Warning: validateDOMNesting(...): <div> cannot appear
as a descendant of <p>.`

- Change `renderSuffix` to `suffix` fixes
`React does not recognize the renderSuffix prop on a DOM element.
If you intentionally want it to appear in the DOM as a custom
attribute, spell it as lowercase rendersuffix instead.`

- Add key attribute to list fixes
`Warning: Each child in a list should have a unique "key" prop.`

- Adding checks that were causing some crashed the first time
a page was open with no cache.
Fixes cockroachdb#97902

Release note: None
@maryliag maryliag requested review from a team March 3, 2023 21:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag
Copy link
Contributor Author

maryliag commented Mar 3, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 3, 2023

Build succeeded:

@craig craig bot merged commit bf7dcba into cockroachdb:master Mar 3, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 3, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4e1e936 to blathers/backport-release-22.2-98004: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@maryliag maryliag deleted the remove-errors branch March 6, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error on reading transactionInsights
3 participants