-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: server: add cpu profiler #97929
release-22.2: server: add cpu profiler #97929
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once CI passes - I went through the diff compared to the original PR and everything looks consistent.
I think we just have a small linter error (I guess this linter rule must no longer exist on master
)
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @smg260 and @srosenberg)
This PR adds a cpu profiler to the server package. The following cluster settings have been added to configure the cpu profiler: - server.cpu_profile.cpu_usage_combined_threshold is the baseline value for when cpu profiles should be taken - server.cpu_profile.interval is when the high water mark resets to the cpu_usage_combined_threshold value - server.cpu_profile.duration is how long a cpu profile is taken - server.cpu_profile.enabled is whether the on/off switch of the cpu profiler Fixes: cockroachdb#75799 Release note: None
d11f60d
to
8c7b666
Compare
TFTR! Github CI failure seems like an unrelated linting error so I'm merging this bors r+ |
This PR was included in a batch that successfully built, but then failed to merge into release-22.2 (it was a non-fast-forward update). It will be automatically retried. |
bors r- We don't use bors in backports, you just click "Merge pull request" when ready. |
Canceled. |
Backport 1/1 commits from #95623.
/cc @cockroachdb/release
This PR adds a cpu profiler to the server package.
The following cluster settings have been added to configure
the cpu profiler:
value for when cpu profiles should be taken
the cpu_usage_combined_threshold value
cpu profiler
Fixes: #75799
Release note: None
Release justification: low risk, high benefit changes to
existing functionality.