Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion: remove three 22_2 version gates owned by SQL Queries #97819

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

yuzefovich
Copy link
Member

This commit removes the following version gates:

  • V22_2TrigramInvertedIndexes
  • V22_2AlterSystemSQLInstancesAddLocality (as well as the corresponding migration)
  • V22_2DeleteRequestReturnKey.

Fixes: #96757.

Release note: None

This commit removes the following version gates:
- V22_2TrigramInvertedIndexes
- V22_2AlterSystemSQLInstancesAddLocality (as well as the corresponding
migration)
- V22_2DeleteRequestReturnKey.

Release note: None
@yuzefovich yuzefovich requested review from a team February 28, 2023 23:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich
Copy link
Member Author

@cockroachdb/sql-queries anyone care to give a stamp?

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 7, 2023

Build failed:

@yuzefovich
Copy link
Member Author

unrelated flake

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 7, 2023

Build succeeded:

@craig craig bot merged commit 43a25a0 into cockroachdb:master Mar 7, 2023
@yuzefovich yuzefovich deleted the version-gates branch March 7, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql queries: remove V22_2 gates and related logic/migrations/etc
3 participants