-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: backport two disk-stall enhancements #97667
release-22.1: backport two disk-stall enhancements #97667
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Looks like we missed these in the flurry of activity. I suspect these should fix the roachtest failures we're seeing on 22.1.x. |
To be defensive, sequence the EventListener responsible for crashing the process during a disk stall first, before the Pebble logging event listener. Informs cockroachdb#94373. Epic: None Release note: None
4a71fd2
to
50dc7b3
Compare
The pebble logger could block if we're experiencing a slow / stalling disk. If the call to the pebble logger is synchronous from the EventListener passed into Pebble, it could end up slowing down Pebble's internal disk health checks as those rely on EventListener methods being quick to run. This change updates the logging event listener to asynchronously call the logger on a DiskSlow event. Related to cockroachdb#94373. Epic: none Release note: None.
50dc7b3
to
2dac29a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @jbowens, and @RaduBerinde)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for tracking these down!
Merging. TFTRs! |
This is a backport of #95863 and #96021 to 22.1.x.
Fix #97026.
Fix #97001.
Fix #97013.
Release justification: Low risk bug fixes.
storage: reorder EventListeners
To be defensive, sequence the EventListener responsible for crashing the
process during a disk stall first, before the Pebble logging event listener.
Informs #94373.
Epic: None
Release note: None
storage: Make logging event listener async for DiskSlow
The pebble logger could block if we're experiencing a slow
/ stalling disk. If the call to the pebble logger is synchronous
from the EventListener passed into Pebble, it could end up slowing
down Pebble's internal disk health checks as those rely on EventListener
methods being quick to run.
This change updates the logging event listener to asynchronously
call the logger on a DiskSlow event.
Related to #94373.
Epic: none
Release note: None.