Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show recent executions even without lock information #97662

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

maryliag
Copy link
Contributor

Previously, if the call to retrieve contention/lock information returned a max size limit error, we were not displaying any data on the recent executions.
Now we show the data returned with a warning that cluster locks information might be missing.

Part Of #96184

Screenshot 2023-02-24 at 6 25 39 PM

Release note (ui change): Still show active execution information when there is a max size limit error.

@maryliag maryliag requested review from a team February 24, 2023 23:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, if the call to retrieve contention/lock
information returned a max size limit error, we were not displaying
any data on the recent executions.
Now we show the data returned with a warning that cluster locks
information might be missing.

Part Of cockroachdb#96184

Release note (ui change): Still show active execution information
when there is a max size limit error.
@maryliag maryliag force-pushed the max-size-contention branch from 482c982 to efdf5aa Compare February 25, 2023 00:12
@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 27, 2023

Build succeeded:

@craig craig bot merged commit bfc40a7 into cockroachdb:master Feb 27, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 27, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from efdf5aa to blathers/backport-release-22.2-97662: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants