Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils,grpcutil: fixing comments #97622

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

aliher1911
Copy link
Contributor

This is follow up PR to loss of quorum recovery changes and it adds clarifying comments to the methods.
There are no functional changes.

Release note: None

This is follow up PR to loss of quorum recovery changes and it adds
clarifying comments to the methods.
There are no functional changes.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Feb 24, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@aliher1911 aliher1911 self-assigned this Feb 24, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aliher1911 aliher1911 marked this pull request as ready for review February 24, 2023 16:23
@aliher1911 aliher1911 requested review from knz and a team February 24, 2023 16:23
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@aliher1911
Copy link
Contributor Author

bors r=knz

@craig
Copy link
Contributor

craig bot commented Mar 1, 2023

Build succeeded:

@craig craig bot merged commit c82f0b9 into cockroachdb:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants