sql: skip mixed version test if setup stmt is unimplemented in old version #97577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
chengxiong-ruan
force-pushed
the
skip-test-if-setup-stmt-unimplemented
branch
from
52f64c6 to
102d846
Compare
fqazi
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan)
chengxiong-ruan
force-pushed
the
skip-test-if-setup-stmt-unimplemented
branch
from
102d846 to
214235b
Compare
chengxiong-ruan
force-pushed
the
skip-test-if-setup-stmt-unimplemented
branch
4 times, most recently
from
f6cf513 to
969f80c
Compare
…rsion This patch add additional error checking so that we can skip a test if the any of the setup statement is unimplemented. This is useful to skip a mixed version schema changer test when implementing new features which are version gated. Epic: None Release note: None
chengxiong-ruan
force-pushed
the
skip-test-if-setup-stmt-unimplemented
branch
from
969f80c to
49b5ecd
Compare
|
TFTR! |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add additional error checking so that we can skip a test if the any of the setup statement is unimplemented. This is useful to skip a mixed version schema changer test when implementing new features which are version gated.
Epic: None
Release note: None