sql/opt: support anonymous subqueries in CREATE FUNCTION #97544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
There was a problem hiding this comment.
Thanks for this! The f_subquery_unaliased and f_ambiguous tests in pkg/sql/logictest/testdata/logic_test/udf_star should no longer have an error, so you'll need to update the logic test:
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @michae2)
knz
force-pushed
the
20230222-anon-subquery
branch
from
9c49457 to
a21fe3b
Compare
Done. (Turns out it wasn't the only one!) |
knz
force-pushed
the
20230222-anon-subquery
branch
from
a21fe3b to
2d42c84
Compare
DrewKimball
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:
Release note (bug fix): CockroachDB now supports using subqueries in UDFs without an AS clause, for consistency with the syntax supported outside of UDFs. (Subqueries without an AS clause is a CRDB-specific extension.)
|
The new tests revealed this separate issue #97546, which i will not let hold up this PR. |
knz
force-pushed
the
20230222-anon-subquery
branch
from
2d42c84 to
c5fb4a5
Compare
craig bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
97515: sql: allow stars inside view definitions r=DrewKimball,rharding6373 a=knz First commit from #97544. Fixes #10028. Release note (sql change): It is now possible to use `*` inside CREATE VIEW. The list of columns is expanded at the time the view is created, so that new columns added after the view was defined are not included in the view. This behavior is the same as PostgreSQL. Co-authored-by: Raphael 'kena' Poss <[email protected]>
|
Thanks @knz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #97515.
Fixes #96375.
Release note (bug fix): CockroachDB now supports using subqueries in UDFs without an AS clause, for consistency with the syntax supported outside of UDFs. (Subqueries without an AS clause is a CRDB-specific extension.)