c2c: gather perf metrics from prometheus #97465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
requested review from
herkolategan and
smg260
and removed request for
a team
|
This change is |
|
From the logs of a |
msbutler
force-pushed
the
butler-bench-alt
branch
3 times, most recently
from
a4e563b to
48c0e08
Compare
msbutler
force-pushed
the
butler-bench-alt
branch
from
d3185e2 to
52c78e5
Compare
stevendanna
approved these changes
Feb 27, 2023
| if err != nil { | ||
| t.L().Errorf("Could not query prom %s", err.Error()) | ||
| } | ||
| metricSnap[name] = sumOverLabel(point, stat.LabelName) |
There was a problem hiding this comment.
Is it possible to put this summation into the Query like you can in the grafana graph?
There was a problem hiding this comment.
Sadly, not with this collector.CollectPoint() api. I'll leave a todo and file an issue.
c2c roachtest performance metrics are now gathered by a prom/grafana instance running locally on the roachprod cluster. This change allows us to gather and process any metrics exposed to the crdb prom endpoint. Specifically, we now gather: `capacity_used`, `replication_logical_bytes`, `replication_sst_bytes` at various points during the c2c roachtest, allowing us to measure: - Initial Scan Throughput: initial scan size / initial scan duration - Workload Throughput: data ingested during workload / workload duration - Cutover Throughput: (data ingested between cutover time and cutover cmd) / (cutover process duration) where the size of these operations can be measured as either physical replicated bytes, logical ingested bytes, or physical ingested bytes on the source cluster. This patch also fixes a recent bug which mislabeled src cluster throughput as initial scan throughput. Epic: None
This patch streamlines how we remove ru limiting for roachtests that use tenants. For the c2c tests specifically, we know remove the limits on the dst cluster tenant as soon as the replication stream begins. Release note: None
Epic: none Release note: none
msbutler
force-pushed
the
butler-bench-alt
branch
from
52c78e5 to
4610bc6
Compare
|
TFTR! bors r=stevendanna |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c2c roachtest performance metrics are now gathered by a prom/grafana instance running locally on the roachprod cluster. This change allows us to gather and process any metrics exposed to the crdb prom endpoint. Specifically, we now gather:
capacity_used,replication_logical_bytes,replication_sst_bytesat various points during the c2c roachtest, allowing us to measure:where the size of these operations can be measured as either physical replicated bytes, logical ingested bytes, or physical ingested bytes on the source cluster.
This patch also fixes a recent bug which mislabeled src cluster throughput as initial scan throughput.
Informs #89176
Release note: None