storage: write min version file with checkpoint #97410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require the min version filename to open a store. If it doesn't exist, we assume the store doesn't exist which can lead to a confusing message if just the min version file is missing. This commit makes this message more useful. Informs cockroachdb#97337 Release note: none Epic: none
|
This change is |
We now write out the min version file with checkpoints generated through the storage layer. This allows checkpoints to be opened with the cockroach storage layer (not just with the low level pebble tool). Informs cockroachdb#97337 Release note: None Epic: none
RaduBerinde
force-pushed
the
better-msg
branch
from
662c75c to
15351c0
Compare
|
Confirmed that the |
jbowens
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
TFTR! CI failure looks like an unrelated flake. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage: better error for missing min version file
We require the min version filename to open a store. If it doesn't
exist, we assume the store doesn't exist which can lead to a confusing
message if just the min version file is missing. This commit makes
this message more useful.
Informs #97337
Release note: none
Epic: none
storage: write min version file with checkpoint
We now write out the min version file with checkpoints generated
through the storage layer. This allows checkpoints to be opened with
the cockroach storage layer (not just with the low level pebble tool).
Fixes #97337
Release note: None
Epic: none