backupccl: fix typo in restore roachtest driver around aost selection #97217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
requested review from
smg260 and
renatolabs
and removed request for
a team,
smg260 and
renatolabs
|
This change is |
lidorcarmel
approved these changes
Feb 15, 2023
The previous select query to get the start time of the ith backup in the chain was incorrect. This patch revises that query to correctly get the end time of the ith backup in the chain. The end time is used now as it better reflects how a user would select an AOST for a restore. Release note: None Epic: none
msbutler
force-pushed
the
butler-restore-test-typo
branch
from
21e0223 to
8c4463c
Compare
|
bors r=lidorcarmel |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous select query to get the start time of the ith backup in the chain was incorrect. This patch revises that query to correctly get the end time of the ith backup in the chain. The end time is used now as it better reflects how a user would select an AOST for a restore.
Release note: None
Epic: none