Do not block Store.Start while waiting for the first gossip. #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // to complete their initialization. In particular, this includes | ||
| // gossiping. In some cases this may block until the range GC queue | ||
| // has completed its scan. Only for testing. | ||
| func (s *Store) WaitForInit() { |
There was a problem hiding this comment.
does this need to be exported?
There was a problem hiding this comment.
Yes, it's called from storage/client_test.go which is in package storage_test.
|
LGTM |
1 similar comment
|
LGTM |
In tests related to removed replicas, the first gossip run will block while attempting to acquire the lease until the range GC queue can determine that the range has been removed.
bdarnell
force-pushed
the
non-blocking-gossip
branch
from
a259f47 to
d13eba7
Compare
bdarnell
added a commit
that referenced
this pull request
May 8, 2015
Do not block Store.Start while waiting for the first gossip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests related to removed replicas, the first gossip run will block
while attempting to acquire the lease until the range GC queue can
determine that the range has been removed.