kvserver: extract writeUnreplicatedSST #96882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be fully extracted mechanically in next commit. Review with whitespace suppressed for best results. The only real change is that we're dropping the raft entry cache a tad later now. But, the order here is completely irrelevant; the raft entry cache doesn't care if we've created (not ingested) some SSTs yet. Epic: CRDB-220 Release note: None
CTRL-X CTRL-V Epic: CRDB-220 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
pav-kv
approved these changes
Feb 9, 2023
Epic: none Epic: CRDB-8035
Epic: CRDB-220 Release note: None
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts a standalone method
writeUnreplicatedSSTthat can be movedto
kvstorageat an appropriate time.This is a sister PR to #96871, which does the same to some other SSTs created
in
applySnapshot.Epic: CRDB-220
Release note: None