kvserver: use replicasByKey addition func in snapshot path #96870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: none Epic: none
Release note: none Epic: none
Release note: none Epic: none
|
This change is |
|
@tbg A few small commits to review one by one. |
pav-kv
force-pushed
the
reuse_add_to_replicas_by_key
branch
from
73ae8e7 to
ec91985
Compare
tbg
approved these changes
Feb 9, 2023
|
Some tests timed out. Possibly there is a deadlock. The reason probably is: |
pav-kv
force-pushed
the
reuse_add_to_replicas_by_key
branch
3 times, most recently
from
eff5ec4 to
00fbcbd
Compare
|
bors r=tbg |
This commit makes one step towards better code sharing between Replica initialization paths: split trigger and snapshot application. It makes both to use the same method to check and insert the initialized Replica to replicasByKey map. Release note: none Epic: none
pav-kv
force-pushed
the
reuse_add_to_replicas_by_key
branch
from
00fbcbd to
f5bbd77
Compare
|
Canceled. |
|
bors cancel |
|
bors r=tbg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes one step towards better code sharing between
Replicainitialization paths: split trigger and snapshot application. It makes both to use the same method to check and insert the initializedReplicatoreplicasByKeymap.Touches #94912