ui: txn insights details fixes #96832
Conversation
|
This change is |
This commit fixes a bug in when we show the error message due to cluster upgrade in the UI. The bug caused the message to show more frequently than desired. Epic: none Release note: None
xinhaoz
force-pushed
the
fix-error-msg
branch
from
1418cbf to
5b83bde
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 3 of 4 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
pkg/ui/workspaces/cluster-ui/src/insights/workloadInsightDetails/transactionInsightDetails.tsx line 151 at r2 (raw file):
<Tabs.TabPane tab="Overview" key={TabKeysEnum.OVERVIEW}> <TransactionInsightDetailsOverviewTab isLoading={txnDetails == null && fetches.current === 0}
if you're trying 3 times, should this be txnDetails == null && fetches.current < MAX_REQ_ATTEMPTS ?
xinhaoz
force-pushed
the
fix-error-msg
branch
2 times, most recently
from
53a0132 to
4194e9a
Compare
|
Previously, maryliag (Marylia Gutierrez) wrote…
Ah yes, nice catch. Fixed! |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4, 4 of 4 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:
Previously, attempts to fetch missing txn insights details was unbounded. This could happen in the case where the txn insight is not found in the server. Instead of retrying until we have complete information, we now limit the number of attempts to fetch txn insight details to 3 per page load. In addition, this commit fixes the case where a requested txn insight that isn't found in the server would show the loading spinner forever. Epic: none Release note (ui change): Txn insights that were not found will display a message `Insight not found`.
The txn details api was missing a null check when reading the results of contention information, which lead to the showing of an error when we should just not show any contention details. Epic: none Release note: None
xinhaoz
force-pushed
the
fix-error-msg
branch
from
4194e9a to
e350956
Compare
|
TFTR! |
|
Build succeeded: |
See individual commits.