*: Properly support partial UNIQUE WITHOUT INDEX referencing type descs #96681
Conversation
|
This change is |
Xiang-Gu
force-pushed
the
uwi_support_ref_to_descs
branch
2 times, most recently
from
a5b2274 to
d5b662e
Compare
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
pkg/sql/unique_without_index_test.go line 53 at r1 (raw file):
tdb.Exec(t, "CREATE TYPE typ AS ENUM ('a', 'b');") tdb.Exec(t, "CREATE TABLE t (i INT PRIMARY KEY, j STRING);") tdb.Exec(t, "ALTER TABLE t ADD UNIQUE WITHOUT INDEX (j) WHERE (j::typ != 'a');")
Can you ensure that dropping the enum member fails because it's referenced by the constraint? Then ensure that it succeeds after you drop the constraint?
There was a problem hiding this comment.
Should this have a release note?
Reviewable status:
Xiang-Gu
force-pushed
the
uwi_support_ref_to_descs
branch
from
d5b662e to
7189289
Compare
There was a problem hiding this comment.
I intentionally didn't put one because this feature UNIQUE WITHOUT INDEX is hidden from users (both in code and in doc).
Reviewable status:
Previously if a partial UNIQUE WITHOUT INDEX references a type descriptor in its predicate, we didn't add back-references in the type descriptor, both in the legacy and declarative schema changer. This commit fixes this. Release note: None
Xiang-Gu
force-pushed
the
uwi_support_ref_to_descs
branch
from
7189289 to
f113af3
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Previously if a partial UNIQUE WITHOUT INDEX references a type descriptor in its predicate, we didn't add back-references in the type descriptor, both in the legacy and declarative schema changer. This commit fixes this.
Fixes #96678
Release note: None