Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: only backup active tenants #96679

Merged
merged 1 commit into from
Feb 7, 2023
Merged

backupccl: only backup active tenants #96679

merged 1 commit into from
Feb 7, 2023

Conversation

dt
Copy link
Member

@dt dt commented Feb 6, 2023

Release note: none.
Epic: none.
Fixes: #89997.

@dt
backupccl: only backup active tenants
36b4329 
Release note: none.
Epic: none.
Fixes: cockroachdb#89997.
@dt dt requested review from knz and stevendanna February 6, 2023 20:28
@dt dt requested a review from a team as a code owner February 6, 2023 20:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

stevendanna
stevendanna approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. It also saves us from having to synthesise GC Jobs for dropping tenants.

@dt
Copy link
Member Author

dt commented Feb 7, 2023

saves us from having to synthesise GC Jobs

More importantly, if they are actively clearRanging, or if they're adding with AddSSTable, then we can't reliably read their span anyway and should stay out.

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build failed:

@dt
Copy link
Member Author

dt commented Feb 7, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build succeeded:

@craig craig bot merged commit 75eb88d into cockroachdb:master Feb 7, 2023
@dt dt deleted the backup-active branch February 22, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

@knz knz knz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

backupccl: backup does not check tenant active column
4 participants
@dt @cockroach-teamcity @knz @stevendanna