Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix TestPebbleMetricEventListener #96651

Merged

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Feb 6, 2023

In #96021 handling of disk slow events was made asynchronous. This introduced a race during Close where the goroutine logging could still be inflight.

Fix #96635.

Epic: None
Release note: None

In cockroachdb#96021 handling of disk slow events was made asynchronous. This introduced a
race during Close where the goroutine logging could still be inflight.

Fix cockroachdb#96635.

Epic: None
Release note: None
@jbowens jbowens requested a review from itsbilal February 6, 2023 16:38
@jbowens jbowens requested a review from a team as a code owner February 6, 2023 16:38
@blathers-crl
Copy link

blathers-crl bot commented Feb 6, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbowens
Copy link
Collaborator Author

jbowens commented Feb 6, 2023

TFTR!

bors r=itsbilal

@craig
Copy link
Contributor

craig bot commented Feb 6, 2023

Build succeeded:

@craig craig bot merged commit c9dde80 into cockroachdb:master Feb 6, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 6, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 27df3cb to blathers/backport-release-22.2-96651: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@jbowens jbowens deleted the deflake-TestPebbleMetricEventListener branch February 6, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: TestPebbleMetricEventListener failed
3 participants