Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: deflake TestParseClientProvidedSessionParameters #96499

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 3, 2023

fixes #96492

pgx starts an internal goroutine if a context is cancelled. We need to wait for it to be done in order to avoid a leaked goroutine in the test.

Release note: None

@rafiss rafiss requested review from ZhouXing19 and a team February 3, 2023 15:20
@rafiss rafiss requested a review from a team as a code owner February 3, 2023 15:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pgx starts an internal goroutine if a context is cancelled. We need to
wait for it to be done in order to avoid a leaked goroutine in the test.

Release note: None
@rafiss rafiss force-pushed the fix-async-close-race branch from 904c2f7 to b6b6cf3 Compare February 6, 2023 19:27
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 7, 2023

tftr!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build succeeded:

@craig craig bot merged commit f640acb into cockroachdb:master Feb 7, 2023
@rafiss rafiss deleted the fix-async-close-race branch February 7, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/pgwire: TestParseClientProvidedSessionParameters failed
3 participants