sql: add test for builtin that belongs to information_schema #96468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
force-pushed
the
qualify-info-schema
branch
from
285ad70 to
d2f1703
Compare
ZhouXing19
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Seems that it has been fixed by 3f50d81 but we can still add the test for logic_test/pg_catalog
rafiss
force-pushed
the
qualify-info-schema
branch
from
d2f1703 to
0121d6d
Compare
|
tftr! i didn't see that commit go in earlier bors r+ |
rafiss
changed the title
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
This tests the change in 3f50d81 Release note: None
rafiss
force-pushed
the
qualify-info-schema
branch
from
0121d6d to
cba72da
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: None
This tests the change in 3f50d81
Release note: None