-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pubsub dependency #96449
update pubsub dependency #96449
Conversation
78989dd
to
da18080
Compare
LGTM - this change also opens a door for an improvement in CockroachDB, that of propagating context cancellation through RPC dials. We might notice stability improvements as a result. LGTM This one would need an extra pair of eyes from our KV and storage team, as we're relying on LGTM |
da18080
to
7b28ab1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval is only valid for the specific things i've reviewed.
7b28ab1
to
b9ce872
Compare
googleapis/google-api-go-client@v0.80.0...v0.103.0 is a large diff, but appears to be almost entirely boilerplate and codegen. I don’t notice any relevant feature changes in there. |
google/go-cmp@v0.5.8...v0.5.9 looks like uninteresting changes. |
census-instrumentation/opencensus-go@v0.23.0...v0.24.0 Looks like mostly optimizations, and one fix that appears to prevent leaking / hanging goroutines (which was the motivation of this overall dep update in the first place cc @ZhouXing19). |
googleapis/go-genproto@f39f71e...67e5cbc appears to be all codegen and dependency updates, I don’t detect meaningful changes in there. |
b9ce872
to
4d167b1
Compare
4d167b1
to
d78ba57
Compare
Because googleapis/google-cloud-go@kms/v1.1.0...kms/v1.6.0 and googleapis/google-cloud-go@pubsub/v1.16.0...pubsub/v1.28.0 are:
...I think we can reasonably make the call that we trust it, and we will depend on our tests to detect regressions. @adityamaru @knz agree? |
d78ba57
to
b0ced58
Compare
b0ced58
to
64dee1a
Compare
64dee1a
to
f0632bc
Compare
f0632bc
to
604deea
Compare
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
6dec397
to
99efc5b
Compare
99efc5b
to
b0ea9cb
Compare
Includes several sub-dependency updates, see cockroachdb#96449 Note removal of redirect for google.golang.org/api v0.80.0 (bottom of go.mod). I believe that fork existed to get upstream fixes earlier, and the later version update includes that fix.
b0ea9cb
to
e846fce
Compare
Removed redirect: ...as this fork by @rhu713 was an eager backport of an upstream change. That change is in the later version in this PR. |
bors r+ |
Build succeeded: |
Motivated by an apparent shortcoming in a dependency (internal conversation).
This brings in updates for sub dependencies, here are some diffs:
@adityamaru would you please review KMS changes? This link above is not great for reviewing the history of that submodule, perhaps you can find a better way?
@knz reviewed
@knz reviewed
@nvanbenschoten reviewed
@shermanCRL reviewed
@knz reviewed
@shermanCRL reviewed
@shermanCRL reviewed
@shermanCRL reviewed
Jira: none
Epic: none