Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: add 'aws-weekly' tag to restore/tpce/32tb test #96445

Merged
merged 1 commit into from
Feb 3, 2023
Merged

backupccl: add 'aws-weekly' tag to restore/tpce/32tb test #96445

merged 1 commit into from
Feb 3, 2023

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Feb 2, 2023

Epic: none

Release note: None

@msbutler msbutler requested a review from healthy-pod February 2, 2023 17:23
@msbutler msbutler self-assigned this Feb 2, 2023
@msbutler msbutler requested a review from a team as a code owner February 2, 2023 17:23
@msbutler msbutler requested review from srosenberg and smg260 and removed request for a team February 2, 2023 17:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

healthy-pod
healthy-pod approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@healthy-pod healthy-pod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this test to run only in aws's weekly? If you want it on both gcp's and aws's weeklies you need keep both tags weekly and aws-weekly.

@msbutler
Copy link
Collaborator Author

msbutler commented Feb 2, 2023

ty for the stamp! I only want it on aws-weekly

@msbutler msbutler force-pushed the butler-restore-weekly-aws branch from f21c1b9 to ab11c55 Compare February 2, 2023 18:24
@msbutler msbutler requested a review from smg260 February 2, 2023 18:24
@msbutler
Copy link
Collaborator Author

msbutler commented Feb 2, 2023

note the small change I made to test_registry.go to prevent roachtest unit tests from failing.

@msbutler msbutler force-pushed the butler-restore-weekly-aws branch from ab11c55 to 8f36e6e Compare February 2, 2023 18:26
@msbutler
Copy link
Collaborator Author

msbutler commented Feb 2, 2023

bors r=healthy-pod

@msbutler
Copy link
Collaborator Author

msbutler commented Feb 2, 2023

bors cancel

@craig
Copy link
Contributor

craig bot commented Feb 2, 2023

Canceled.

@renatolabs
Copy link
Contributor

A little late to the party here, but can we consider keeping the weekly tag mandatory for every weekly test? It's convenient to be able to list tag:weekly to find out all tests that run weekly instead of nightly (it's way too easy to forget about aws-weekly).

The Tags field in TestSpec is a list, so we can tag this test with [weekly, aws-weekly].

@msbutler msbutler force-pushed the butler-restore-weekly-aws branch from 8f36e6e to f3a67b0 Compare February 2, 2023 20:31
@msbutler msbutler force-pushed the butler-restore-weekly-aws branch from f3a67b0 to 9e2332c Compare February 2, 2023 20:48
renatolabs
renatolabs approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@msbutler
Copy link
Collaborator Author

msbutler commented Feb 2, 2023

bors r=healthy-pod, renatolabs

@craig
Copy link
Contributor

craig bot commented Feb 2, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Feb 3, 2023

Build succeeded:

@craig craig bot merged commit dd97d0c into cockroachdb:master Feb 3, 2023
@msbutler msbutler deleted the butler-restore-weekly-aws branch February 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@healthy-pod healthy-pod healthy-pod approved these changes

@smg260 smg260 Awaiting requested review from smg260

Assignees

@msbutler msbutler

Labels
T-disaster-recovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msbutler @cockroach-teamcity @renatolabs @healthy-pod