Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: explain create function op #96253

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

rharding6373
Copy link
Collaborator

EXPLAIN CREATE FUNCTION ... now emits some output instead of failing.

Fixes #96046

Epic: none
Release note: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rharding6373 rharding6373 marked this pull request as ready for review January 31, 2023 01:01
@rharding6373 rharding6373 requested a review from a team as a code owner January 31, 2023 01:01
Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! :lgtm:

Let's backport this to 22.2. I've added the label.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @rharding6373)

`EXPLAIN CREATE FUNCTION ...` now emits some output instead of failing.

Fixes cockroachdb#96046

Epic: none
Release note: none
@rharding6373
Copy link
Collaborator Author

TFTRs! And for adding the backport label.

bors r=msirek,mgartner

@craig
Copy link
Contributor

craig bot commented Jan 31, 2023

Build succeeded:

@craig craig bot merged commit 8ae413b into cockroachdb:master Jan 31, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 31, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 85cf1dc to blathers/backport-release-22.2-96253: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error on EXPLAIN CREATE FUNCTION
4 participants