testcluster: always wait for full replication #9624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it considerably less likely that database creation will cause replication to stall in our benchmarks. The underlying cause remains unknown. Updates #8081.
|
Well, this appears to make matters worse (by surfacing more instances of this bug). cc @petermattis ( |
|
I'll take a look tomorrow as I have a school event to attend tonight. |
petermattis
reviewed
Oct 26, 2016
| @@ -177,6 +177,12 @@ func StartTestCluster(t testing.TB, nodes int, args base.TestClusterArgs) *TestC | |||
| tc.stopper.AddCloser(stop.CloserFn(tc.stopServers)) | |||
|
|
|||
| tc.waitForStores(t) | |||
|
|
|||
| // TODO(tamird): consider removing this when #8081 is addressed. | |||
| if err := tc.WaitForFullReplication(); err != nil { | |||
There was a problem hiding this comment.
This will never complete if args.ReplicationMode == base.ReplicationManual, which it is in TestLeaseInfoRequest. Try:
if args.ReplicationMode == base.ReplicationAuto {
if err := tc.WaitForFullReplication(); err != nil {
t.Fatal(err)
}
}
petermattis
added a commit
to petermattis/cockroach
that referenced
this pull request
Oct 26, 2016
petermattis
added a commit
to petermattis/cockroach
that referenced
this pull request
Oct 26, 2016
petermattis
added a commit
to petermattis/cockroach
that referenced
this pull request
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it considerably less likely that database creation will cause
replication to stall in our benchmarks.
The underlying cause remains unknown.
Updates #8081.
This change is