Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: move RandString to util to break coldata->rangden->sem/tree dep #96229

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

cucaroach
Copy link
Contributor

@cucaroach cucaroach commented Jan 30, 2023

Epic: CRDB-18892
Informs: #91831
Release note: None

@blathers-crl
Copy link

blathers-crl bot commented Jan 30, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cucaroach cucaroach force-pushed the vec-encoding2 branch 3 times, most recently from 3ed0fdb to aa392e4 Compare January 30, 2023 23:58
@cucaroach cucaroach marked this pull request as ready for review January 31, 2023 12:19
@cucaroach cucaroach requested a review from a team as a code owner January 31, 2023 12:19
@cucaroach cucaroach requested review from mgartner and removed request for mgartner January 31, 2023 12:19
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)


pkg/util/strings.go line 163 at r1 (raw file):

// RandString generates a random string of the desired length from the
// input alphabet.
func RandString(rng *rand.Rand, length int, alphabet string) string {

nit: An alternative would be to put this in the strutil package and rename this just Rand.

@cucaroach
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 31, 2023

Build succeeded:

@craig craig bot merged commit 58762ac into cockroachdb:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants