Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add mixed version test for system.role_members user ids upgrade #96031

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Jan 26, 2023

This patch adds a mixed version logictest that ensures that GRANT ROLE
continues to work properly in a cluster with both 22.2 and 23.1 nodes
(i.e. nodes that have run the system.role_members user ids upgrade).

Part of #92342

Release note: None

@andyyang890 andyyang890 requested review from rafiss, ZhouXing19 and a team January 26, 2023 22:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 force-pushed the logictest_role_members branch 4 times, most recently from a3649e7 to 4acdedc Compare February 1, 2023 04:12
@andyyang890
Copy link
Collaborator Author

andyyang890 commented Feb 1, 2023

Depends on #96282

@andyyang890 andyyang890 marked this pull request as ready for review February 1, 2023 04:17
@andyyang890 andyyang890 force-pushed the logictest_role_members branch 2 times, most recently from 2538d07 to 9df2565 Compare February 3, 2023 05:08
This patch adds a mixed version logictest that ensures that GRANT ROLE
continues to work properly in a cluster with both 22.2 and 23.1 nodes
(i.e. nodes that have run the system.role_members user ids upgrade).

Release note: None
@andyyang890 andyyang890 force-pushed the logictest_role_members branch from 9df2565 to 7cb807e Compare February 3, 2023 05:18
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Feb 9, 2023

Build failed (retrying...):

@craig craig bot merged commit 732c3a7 into cockroachdb:master Feb 9, 2023
@craig
Copy link
Contributor

craig bot commented Feb 9, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants