Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colfetcher: disable direct columnar scans for now #96005

Merged
merged 1 commit into from
Jan 26, 2023
Merged

colfetcher: disable direct columnar scans for now #96005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/sql/colfetcher/cfetcher_wrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/colmem"
"github.com/cockroachdb/cockroach/pkg/sql/execinfra"
"github.com/cockroachdb/cockroach/pkg/storage"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/mon"
)

Expand All @@ -34,16 +33,17 @@ var DirectScansEnabled = settings.RegisterBoolSetting(
settings.TenantWritable,
"sql.distsql.direct_columnar_scans.enabled",
"set to true to enable the 'direct' columnar scans in the KV layer",
directScansEnabledDefault,
)

var directScansEnabledDefault = util.ConstantWithMetamorphicTestBool(
"direct-scans-enabled",
// TODO(yuzefovich, 23.1): update the default to 'true' for multi-tenant
// setups.
false,
)

// TODO(yuzefovich): uncomment this when #95937 is fixed.
//var directScansEnabledDefault = util.ConstantWithMetamorphicTestBool(
// "direct-scans-enabled",
// // TODO(yuzefovich, 23.1): update the default to 'true' for multi-tenant
// // setups.
// false,
//)

// cFetcherWrapper implements the storage.CFetcherWrapper interface. See a large
// comment in storage/col_mvcc.go for more details.
type cFetcherWrapper struct {
Expand Down