kv: add MVCC local timestamp details to ReadWithinUncertaintyIntervalError #96003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lueTimestamp Simple proto field rename. No compatibility concerns. Release note: None Epic: None
…s ClockTimestamp Type check to avoid unnecessary upcasting. Improves type safety. Release note: None Epic: None
Code movement. Release note: None Epic: None
|
This change is |
erikgrinaker
approved these changes
Jan 26, 2023
pkg/roachpb/errors.go
Outdated
| @@ -950,17 +951,17 @@ func (e *ReadWithinUncertaintyIntervalError) SafeFormat(s redact.SafePrinter, _ | |||
|
|
|||
| func (e *ReadWithinUncertaintyIntervalError) printError(p Printer) { | |||
| p.Printf("ReadWithinUncertaintyIntervalError: read at time %s encountered "+ | |||
| "previous write with future timestamp %s within uncertainty interval `t <= "+ | |||
| "(local=%v, global=%v)`; "+ | |||
| "previous write with future timestamp %s (local=%s) within uncertainty interval `t <= "+ | |||
There was a problem hiding this comment.
Would it make sense to omit the (local=%s) when it's equal to valueTs? Seems like that would be the common case, in which case it can be a bit noisy. No strong opinion either way.
…Error This commit adds details about MVCC local timestamps to ReadWithinUncertaintyIntervalErrors. This provides more information about the cause of uncertainty errors. Release note: None Epic: None
nvanbenschoten
force-pushed
the
nvanbenschoten/uncertaintyErr
branch
from
71da68e to
812c5b9
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds details about MVCC local timestamps to ReadWithinUncertaintyIntervalErrors. This provides more information about the cause of uncertainty errors.
The PR also includes a series of minor refactors to clean up this code.
Release note: None
Epic: None