-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: add CommitNoSyncWait and SyncWait to Batch interface #95862
storage: add CommitNoSyncWait and SyncWait to Batch interface #95862
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/storage/pebble_batch.go
line 559 at r1 (raw file):
// Once we do that, document on the storage.Batch interface the meaning of // an error returned from this method and the guarantees that callers have // or don't have after they receive and error from this method.
nit: an eror ...
pkg/storage/pebble_batch.go
line 578 at r1 (raw file):
// Once we do that, document on the storage.Batch interface the meaning of // an error returned from this method and the guarantees that callers have // or don't have after they receive and error from this method.
ditto
d7fff41
to
c1705dc
Compare
c1705dc
to
9ab50a2
Compare
Extracted from cockroachdb#94165. Picks up github.com/cockroachdb/pebble/pull/2117. Release note: None Epic: None
9ab50a2
to
efe12b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR!
bors r=sumeerbhola
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @sumeerbhola)
pkg/storage/pebble_batch.go
line 559 at r1 (raw file):
Previously, sumeerbhola wrote…
nit: an eror ...
Done.
pkg/storage/pebble_batch.go
line 578 at r1 (raw file):
Previously, sumeerbhola wrote…
ditto
Done.
Build succeeded: |
Extracted from #94165.
Picks up cockroachdb/pebble/pull/2117.
Release note: None
Epic: None