Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add CommitNoSyncWait and SyncWait to Batch interface #95862

Merged

Conversation

nvanbenschoten
Copy link
Member

Extracted from #94165.

Picks up cockroachdb/pebble/pull/2117.

Release note: None
Epic: None

@nvanbenschoten nvanbenschoten requested review from a team as code owners January 25, 2023 20:59
@blathers-crl
Copy link

blathers-crl bot commented Jan 25, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)


pkg/storage/pebble_batch.go line 559 at r1 (raw file):

		// Once we do that, document on the storage.Batch interface the meaning of
		// an error returned from this method and the guarantees that callers have
		// or don't have after they receive and error from this method.

nit: an eror ...


pkg/storage/pebble_batch.go line 578 at r1 (raw file):

		// Once we do that, document on the storage.Batch interface the meaning of
		// an error returned from this method and the guarantees that callers have
		// or don't have after they receive and error from this method.

ditto

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/commitNoSyncWait branch 2 times, most recently from d7fff41 to c1705dc Compare January 26, 2023 03:48
@nvanbenschoten nvanbenschoten changed the title storage: add CommitNoSyncWait and SyncWait to Batch interface. storage: add CommitNoSyncWait and SyncWait to Batch interface Jan 26, 2023
@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/commitNoSyncWait branch from c1705dc to 9ab50a2 Compare January 26, 2023 14:44
@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/commitNoSyncWait branch from 9ab50a2 to efe12b8 Compare January 26, 2023 14:44
Copy link
Member Author

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

bors r=sumeerbhola

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @sumeerbhola)


pkg/storage/pebble_batch.go line 559 at r1 (raw file):

Previously, sumeerbhola wrote…

nit: an eror ...

Done.


pkg/storage/pebble_batch.go line 578 at r1 (raw file):

Previously, sumeerbhola wrote…

ditto

Done.

@craig
Copy link
Contributor

craig bot commented Jan 26, 2023

Build succeeded:

@craig craig bot merged commit 3b5bcf0 into cockroachdb:master Jan 26, 2023
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/commitNoSyncWait branch January 26, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants