Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: replace make with dev in test instructions #95840

Merged
merged 1 commit into from
Jan 25, 2023
Merged

opt: replace make with dev in test instructions #95840

merged 1 commit into from
Jan 25, 2023

Conversation

mgartner
Copy link
Collaborator

Epic: None

Release note: None

@mgartner mgartner requested a review from rytaft January 25, 2023 16:58
@mgartner mgartner requested a review from a team as a code owner January 25, 2023 16:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

rytaft
rytaft approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 25, 2023

Build succeeded:

@craig craig bot merged commit 2105cd4 into cockroachdb:master Jan 25, 2023
@mgartner mgartner deleted the fix-test-instructions branch January 25, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

@rytaft rytaft rytaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgartner @cockroach-teamcity @rytaft @rickystewart