[DNM] KV pushdown bisect #95793
Closed
[DNM] KV pushdown bisect #95793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once we add the dependency on `coldata` package into `storage`, there would be an import cycle in dependencies in tests of `coldata` via `randgen` dependency. This commit removes that. Release note: None
This commit introduces `NextKVer` interface which only consists of a single method for returning KVs from somewhere. The interface is then used by the `cFetcher`. Currently, there is only one implementation (`row.KVFetcher`), but soon we'll introduce another one to push the projections into the KV layer. This required moving `MVCCDecodingStrategy` type into `storage` package as well. Note that I chose to not introduce other methods that `cFetcher` is calling on `row.KVFetcher` since they won't be necessary for the pushdown work. Also since (at least currently) the `cFetcher` doesn't use the `spanID` value, we omit it from the interface method signature (it's only used by the lookup joins which aren't yet vectorized). Additionally, this commit moves a single comment to the appropriate place. Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.